Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump @pengx17/electron-forge-maker-appimage #6726

Merged

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 29, 2024

fix #6722
add --no-sandbox --disable-setuid-sandbox to appimage run

Copy link

graphite-app bot commented Apr 29, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Apr 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pengx17 and the rest of your teammates on Graphite Graphite

@pengx17 pengx17 mentioned this pull request Apr 29, 2024
@pengx17 pengx17 force-pushed the xp/04-29-chore_bump_pengx17_electron-forge-maker-appimage branch from 52a8c01 to 0bb58b8 Compare April 29, 2024 04:11
@pengx17 pengx17 changed the base branch from 04-26-fix_core_show_toast_for_requestruninedgeless to xp/04-29-chore_bump_blocksuite April 29, 2024 04:11
@github-actions github-actions bot added the app:electron Related to electron app label Apr 29, 2024
@pengx17 pengx17 marked this pull request as ready for review April 29, 2024 04:11
@pengx17 pengx17 requested a review from EYHN April 29, 2024 04:11
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.78%. Comparing base (905d7d1) to head (964e475).

Additional details and impacted files
@@                        Coverage Diff                         @@
##           xp/04-29-chore_bump_blocksuite    #6726      +/-   ##
==================================================================
+ Coverage                           64.72%   64.78%   +0.06%     
==================================================================
  Files                                 588      588              
  Lines                               27560    27560              
  Branches                             2496     2497       +1     
==================================================================
+ Hits                                17838    17856      +18     
+ Misses                               9444     9426      -18     
  Partials                              278      278              
Flag Coverage Δ
server-test 74.63% <ø> (+0.09%) ⬆️
unittest 41.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Apr 29, 2024

Merge activity

fix #6722
add `--no-sandbox --disable-setuid-sandbox` to appimage run
@Brooooooklyn Brooooooklyn force-pushed the xp/04-29-chore_bump_blocksuite branch from 12c44a5 to 905d7d1 Compare April 29, 2024 04:58
@Brooooooklyn Brooooooklyn force-pushed the xp/04-29-chore_bump_pengx17_electron-forge-maker-appimage branch from 0bb58b8 to 964e475 Compare April 29, 2024 04:58
@Brooooooklyn Brooooooklyn changed the base branch from xp/04-29-chore_bump_blocksuite to canary April 29, 2024 05:11
@graphite-app graphite-app bot merged commit 964e475 into canary Apr 29, 2024
32 checks passed
@graphite-app graphite-app bot deleted the xp/04-29-chore_bump_pengx17_electron-forge-maker-appimage branch April 29, 2024 05:13
pengx17 added a commit that referenced this pull request May 10, 2024
Brooooooklyn pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Unable to Install Affine on Ubuntu 24.04 LTS Due to SUID Sandbox Configuration Issue​
2 participants