Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect parsing and generating of SHA, SHA2, MD5, and MD5_Digest expressions in Presto/Trino dialect #3458

Closed
viplazylmht opened this issue May 11, 2024 · 0 comments · Fixed by #3459

Comments

@viplazylmht
Copy link
Contributor

SQLglot version: 23.15.1
The issue still exists on main

Fully reproducible code snippet

SHA:
Actually:

>>> from sqlglot import parse_one
>>> parse_one("SHA(col_x)", read="").sql(dialect="presto")
'SHA(col_x)'
>>>

Expected output:

>>> from sqlglot import parse_one
>>> parse_one("SHA(col_x)", read="").sql(dialect="presto")
'SHA1(col_x)'
>>>

SHA2:
Actually:

>>> from sqlglot import parse_one
>>> parse_one("SHA2(col_x, 256)", read="").sql(dialect="presto")
'SHA2(col_x, 256)'
>>> parse_one("SHA512(col_x)", read="bigquery").sql(dialect="presto")
'SHA512(col_x, 512)'
>>>

Expected output:

>>> from sqlglot import parse_one
>>> parse_one("SHA2(col_x, 256)", read="").sql(dialect="presto")
'SHA256(col_x)'
>>> parse_one("SHA512(col_x)", read="bigquery").sql(dialect="presto")
'SHA512(col_x)'
>>>

MD5:
Actually:

>>> from sqlglot import parse_one
>>> parse_one("MD5(col_x)", read="").sql(dialect="presto")
'MD5(col_x)'
>>>

Expected output:

>>> from sqlglot import parse_one
>>> parse_one("MD5(col_x)", read="").sql(dialect="presto")
'LOWER(TO_HEX(MD5(col_x)))'
>>>

MD5_Digest:
Actually:

>>> from sqlglot import parse_one
>>> parse_one("MD5_Digest(col_x)", read="").sql(dialect="presto")
'MD5_DIGEST(col_x)'
>>>

Expected output:

>>> from sqlglot import parse_one
>>> parse_one("MD5_Digest(col_x)", read="").sql(dialect="presto")
'MD5(col_x)'
>>>

Official Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant