Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition away from Boost in favor of modern C++ #38

Open
tmcg0 opened this issue Dec 4, 2023 · 0 comments
Open

Transition away from Boost in favor of modern C++ #38

tmcg0 opened this issue Dec 4, 2023 · 0 comments

Comments

@tmcg0
Copy link
Owner

tmcg0 commented Dec 4, 2023

Much like the philosophy of GTSAM, bioslam would be made better by upgrading to at least C++ 17 (likely 20 for future proofing).

This issue tracks boost changes that need to be made, with reference counts in the bioslam codebase as of Dec 3, 2023.

958 references to boost:: in the codebase:

  • 11 to boost::filesystem* -> directly switchable to std::filesystem (C++ 17)
  • 39 to boost::shared_ptr -> std::shared_ptr since C++11
  • 7 to boost::dynamic_pointer_cast -> std::dynamic_pointer_cast for const lvalue reference since C++11
  • 19 to boost::static_pointer_cast -> std::static_pointer_cast for const lvalue reference since C++11
  • 30 to boost::is_base_of -> std::is_base_of since C++11
  • 314 to boost::optional -> std::optional since C++17
  • 538 to boost::none -> std::nullopt since C++17

Note: direct swap replacements will not work because GTSAM often returns boost types, not std types. And these types are not implicitly converted at compile time. Before bioslam can move away from Boost, GTSAM must move away from Boost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant