Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating magnetometer factor to GTSAM's new built-in MagPoseFactor #15

Open
tmcg0 opened this issue Jun 3, 2021 · 0 comments
Open

Updating magnetometer factor to GTSAM's new built-in MagPoseFactor #15

tmcg0 opened this issue Jun 3, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@tmcg0
Copy link
Owner

tmcg0 commented Jun 3, 2021

Background:

When I first started developing bioslam, gtsam only had a magnetometer factor which hooked into a Rot3 object, not a Pose3 object (which are the objects we use to store the pose of IMUs in bioslam). So I developed a custom factor (MagPose3Factor) to add a magnetometer factor to a Pose3 object. Recently, a pull request was merged on gtsam that added a factor which does exactly what I wanted in the first place. It adds the factor MagPoseFactor which is probably way more robust and better-tested than the one I had made. We should switch bioslam to use this.

What to do:

Swap out bioslam's custom MagPose3Factor with the new gtsam built-in MagPoseFactor.

Caveats:

  • This new GTSAM factor just got merged and won't be available in an official GTSAM release til GTSAM 4.1. So don't do this switch until GTSAM 4.1 is out and we force bioslam to require GTSAM >= 4.1.
  • Right now it's in gtsam_unstable, and I'm not sure why. Consider if we want bioslam to depend on gtsam_unstable components.
@tmcg0 tmcg0 added the enhancement New feature or request label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant