Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounting for elevation in time estimations #220

Open
dijitali opened this issue Jan 5, 2021 · 0 comments
Open

Accounting for elevation in time estimations #220

dijitali opened this issue Jan 5, 2021 · 0 comments

Comments

@dijitali
Copy link

dijitali commented Jan 5, 2021

I am interested in enhancing the functionality of this library when adding time data to points. I would like to use elevation data to account for additional time taken when ascending/descending along a route and my intention would be to implement either the Naismith-Langmuir rule or Tobler's hiking function.

However I'm conscious that this functionality would apply solely to walking/hiking, not other activities like cycling or driving, and so might be a bit too opinionated for wider use. Would this still be an accepted addition to this library?

If the suggestion sounds acceptable, are there any considerations for how best to implement?

The immediate issues that came to my mind are:

  1. There are the existing add_missing_times() and fill_time_data_with_regular_intervals() functions for adding time data. To maintain support for these, perhaps they could be given a new, optional argument of estimation_mode with a default of linear for the existing functionality and a value of naismith (or other) for this new functionality?
  2. If both start and end times are available/supplied, this functionality would scale times proportionally based on gradient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant