Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Save Failure When Re-Using Deleted Branch Name #4516

Open
3 tasks done
samsmithssw opened this issue May 2, 2024 · 7 comments
Open
3 tasks done

Content Save Failure When Re-Using Deleted Branch Name #4516

samsmithssw opened this issue May 2, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@samsmithssw
Copy link

Describe the issue that you're seeing. Any Loom videos or screenshots usually help a lot!

@amankumarrr
I made some content changes to a webpage and then when I saved the changes and created a new branch this error came up. All of my changes were lost.

Screenshot 2024-05-02 at 11 03 46 Figure: First error message Screenshot 2024-05-02 at 11 06 05 Figure: Second error message once first was closed

Reproduction

n/a

Steps to reproduce

  1. Make changes
  2. Save changes
  3. Create a branch
  4. Get it merged.
  5. Make changes again
  6. Save changes again
  7. Create a branch with the same branch name.

System Info

n/a

Validations

@samsmithssw samsmithssw added the bug Something isn't working label May 2, 2024
@kldavis4
Copy link
Member

kldavis4 commented May 3, 2024

@samsmithssw what error(s) are there in the browser console?

@samsmithssw
Copy link
Author

samsmithssw commented May 3, 2024

@samsmithssw what error(s) are there in the browser console?

This is the error message in the console @kldavis4

Screenshot 2024-05-03 at 14 53 54 **Figure: console error message**

@kldavis4
Copy link
Member

kldavis4 commented May 4, 2024

thanks - so you are re-using the same branch name? Does it happen when you use a different branch name in step 7?

@amankumarrr
Copy link

@samsmithssw

Hey @kldavis4,

The issue arises when an old branch is deleted on GitHub, and an attempt is made to create a new branch with the same name in Tina. The editorial workflow permits the creation of such a branch since it's deleted on GitHub. However, upon indexing in the Tina Cloud, a conflict arises as the branch already exists there.

Potential solutions:

  1. Implement a check before indexing in the Tina Cloud to prevent the creation of a branch with the same name.
  2. Allow users to delete branches directly from the Tina Cloud.

@kldavis4
Copy link
Member

kldavis4 commented May 5, 2024

There is a webhook that handles deletion of the branch in Tina Cloud when it is deleted from GitHub. It sounds like possibly there is a failure on the deletion.

@amankumarrr
Copy link

@kldavis4 is it something we need to fix it on our end?

@kldavis4
Copy link
Member

kldavis4 commented May 8, 2024

Unclear at this point. Just needs to be investigated because under normal circumstances there shouldn't be a branch naming conflict

@JackDevAU JackDevAU changed the title Content Save Failed Content Save Failure When Re-Using Deleted Branch Name May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants