Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃憖 Spike - upload non image files #4494

Open
4 of 5 tasks
scottgallant opened this issue Apr 18, 2024 Discussed in #3417 · 1 comment
Open
4 of 5 tasks

馃憖 Spike - upload non image files #4494

scottgallant opened this issue Apr 18, 2024 Discussed in #3417 · 1 comment
Assignees
Labels
enhancement New feature or request media

Comments

@scottgallant
Copy link
Member

scottgallant commented Apr 18, 2024

CC @JackDevAU @jeffsee55

User Story

As a marketer, I want to be able to upload videos to the Tina CMS media manager, so I can change the videos on our landing pages

Tasks

  • Investigate effort to implement this
  • Identify UX issues when embedding non-image media files into the rich text field
  • Investigate how we can restrict upload size limits
  • Identify what file types we want (Could be some malicious types that we don't want)
  • Investigate what file types different providers can upload (match them)

Discussed in #3417

@scottgallant scottgallant added enhancement New feature or request media labels Apr 18, 2024
@scottgallant scottgallant changed the title File upload field Spike - upload non image files Apr 22, 2024
@ncn-ssw ncn-ssw changed the title Spike - upload non image files 馃憖 Spike - upload non image files May 7, 2024
@JackDevAU
Copy link
Member

JackDevAU commented May 13, 2024

Hey Team,

Identify UX issues when embedding non-image media files into the rich text field

Since there won't be actual picture previews for these. We are suggesting the following,

  • File type Icons - Due to not having nice previews like images we can instead add icons for file types i.e. pdf says "pdf" and has a pdf image
  • Filter - Add a filter on file type

Investigate how we can restrict upload size limits

This will be done via client (onUpload function) and mainly on the Tina Cloud side.

Identify what file types we want (Could be some malicious types that we don't want)

Let's copy from the greats and only have a small allowed list.

For now lets, include what Cloudinary supports then start adding extras,

  • .pdf
  • .zip
  • DOC
  • XLS
  • PPT
  • TXT
  • ICS or VCS

Investigate what file types different providers can upload (match them)

Cloudinary supports the following and I think we should support these as a start

Image
Figure: Images allowed

Image
Figure: Videos allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request media
Projects
None yet
Development

No branches or pull requests

3 participants