Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve automated testing #76

Open
aendra-rininsland opened this issue Jun 23, 2015 · 2 comments
Open

Improve automated testing #76

aendra-rininsland opened this issue Jun 23, 2015 · 2 comments
Labels
help wanted tests
Milestone
1.1.1

Comments

@aendra-rininsland
Copy link
Contributor

Currently the automated testing is really really brittle and is only unit testing — I haven't upgraded to using Protractor for anything yet. Alas, some tests desperately need E2E testing — embedcodeService, for instance, which launches a modal that's hard to deal with in Jasmine.

Related to #68; this is probably like a day's worth of effort and everything would be so much better.
@aendra-rininsland
Copy link
Contributor Author

Places where better testing is needed:

  • embedcodeOutput (E2E)
  • spreadsheetInput (Unit; E2E)
  • svgOutput (E2E)
  • pngOutput (E2E)
  • configChooser (E2E)
  • c3Service (E2E)

@aendra-rininsland aendra-rininsland modified the milestone: 1.1.0 Jun 23, 2015
@aendra-rininsland
Copy link
Contributor Author

We're above 81% coverage for 1.1.0, which is sufficient for this release. Goal for 1.1.1 is 90%, up to ~100% by 1.1.2.

@aendra-rininsland aendra-rininsland modified the milestones: 1.1.1, 1.1.0 Oct 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted tests
Projects
None yet
Milestone
1.1.1
Development

No branches or pull requests
1 participant
@aendra-rininsland