Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced combination of no_ok and no_performance #83

Open
knorx opened this issue Jan 10, 2022 · 0 comments
Open

Forced combination of no_ok and no_performance #83

knorx opened this issue Jan 10, 2022 · 0 comments

Comments

@knorx
Copy link

knorx commented Jan 10, 2022

There are two flags for compressing the amount of ok messages and disabling performance data. However, currently if you provide no_ok you automatically set no_performance as well:

   global no_performance
   no_performance = args.no_ok

I this a typo? If yes, I suggest to correct it and set args.no_performance. If it is not a typo I would anyways suggest to change it. Everyone who wants to combine the effects can provide both flags. The use case I have, where I want to see compressed OK's, but use performance data anyways, is currently not possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant