When fetching an ACF field that returns WP_Post objects, convert them to Timber\Post

[75th]

Problem

I'm on a project right now that fetches post reference ACF fields all over the place. These are returned as WP_Post objects (or lists thereof). This creates problems when the same template is sent the results of a Timber query in one place and ACF references in another; for instance, if a template gets a WP_Post, it has to use post.permalink, but if it gets a Timber\Post, it has to use post.link.

Solution

Timber\Post::meta() should convert any WP_Post objects it fetches into Timber\Post objects.

Alternatives

Timber\Post could implement the same interface as WP_Post alongside its own stuff, so developers don't have to care as much which kind of object they get. But I'm pretty sure some of those things have been deprecated and removed in the past. (Could be wrong.)

[gchtr]

I think transform_value might be what you’re looking for here: https://timber.github.io/docs/v2/integrations/advanced-custom-fields/#transform-values-to-timber/php-objects.

[75th]

D'oh, you're right, that's perfect. Sorry to bother!

[75th]

This doesn't seem to handle it well when an ACF field that would be converted is empty:

TypeError: Timber\Factory\TermFactory::build(): Argument #1 ($term) must be of type WP_Term, WP_Error given, called in /var/www/html/vendor/timber/timber/src/Factory/TermFactory.php on line 59

The WP_Error in question is simply Empty Term. Is there a good way around this?

[75th]

In TermFactory.php, the from_id method has this:

$wp_term = \get_term($id);

if (!$wp_term) {
    return null;
}

return $this->build($wp_term);

Looks like maybe that !$wp_term should be !$wp_term || $wp_term instanceof \WP_Error perhaps?

EDIT Or perhaps we should check empty($id) before calling get_term()

[Levdbas]

Hi @75th ,

Are you willing to create a PR for handling that specific behavior?

[Levdbas]

In TermFactory.php, the from_id method has this:

$wp_term = \get_term($id);

if (!$wp_term) {
    return null;
}

return $this->build($wp_term);

Looks like maybe that !$wp_term should be !$wp_term || $wp_term instanceof \WP_Error perhaps?

EDIT Or perhaps we should check empty($id) before calling get_term()

What I can see is that get_term only throws an error if the taxonomy does not exist. Was that your case as well @75th ?