Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

erroneous scale_rank values of True #96

Open
rmarianski opened this issue Oct 26, 2017 · 1 comment
Open

erroneous scale_rank values of True #96

rmarianski opened this issue Oct 26, 2017 · 1 comment
Assignees
@rmarianski
Labels
in review

Comments

@rmarianski
Copy link
Member

scale_rank values of True are erroneously appearing in tiles. Example tile:

https://tile.mapzen.com/mapzen/vector/v1/512/all/16/19293/24639.mvt
@rmarianski rmarianski self-assigned this Oct 26, 2017
@rmarianski
Copy link
Member Author

This is happening because both the values of True and 1 are evaluating to the same index in the value to index mapping dict.

rmarianski added a commit that referenced this issue Oct 26, 2017
@rmarianski
Use a separate values index for booleans
d26fc88 
Connects to #96

This prevents collisions between boolean and integer values. In python:
1 == True and 0 == False. But, we don't want these to point to the same
value in the index table.
@rmarianski rmarianski mentioned this issue Oct 26, 2017
Merged
@ghost ghost added the in review label Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmarianski rmarianski

Labels
in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmarianski