Enhancement: Adding Docker configuration for easy setup #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @SecondeJK -- thank you so much for your work here. However, i had forgotten just how heavy Docker configs could be. Is there any chance you could explore implementing this with Sail instead? Or maybe Vessel? Basically something that's simpler, less code in the repo, and also less code for us to maintain. Thanks so much! |
|
No worries, I'll close this and have a look at using Sail (I've not used it before so it should be a good learning exercise!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in Issue #91 : this PR contains a full stack Docker setup with step by step installation instructions in the ReadMe file. The Dockerfile is currently set to PHP7.4, which matches the current requirements of the codebase.
Note: with a Docker setup, this will require maintainence.
Note: the MySQL raw seeder creates an
ozzie_testdatabase which can be then used when creating the test suite for the project.Closes #91.