Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconciliation with immutable forecasts #352

Open
AngelPone opened this issue Apr 24, 2022 · 5 comments
Open

reconciliation with immutable forecasts #352

AngelPone opened this issue Apr 24, 2022 · 5 comments

Comments

@AngelPone
Copy link

Keeping base forecasts of some nodes in the hierarchy immutable after reconciliation can be beneficial and necessary sometimes.
I suggest adding this functionality to forecast.lst_mint_mdl method.
And I can work on it.
References: Zhang, B.; Kang, Y.; Panagiotelis, A.; Li, F. Optimal Reconciliation with Immutable Forecasts. arXiv:2204.09231 [econ, stat] 2022.

@mitchelloharawild
Copy link
Member

This would be great, I recently heard about this work.
I haven't had the chance to read your paper yet, but can this concept be applied to all forms of reconciliation (not just MinT)? I've got a rework in mind for reconciliation to reduce code duplication, and am thinking that a method like this would be nice to make available more generally across all compatible reconciliation techniques.

@AngelPone
Copy link
Author

It can be applied to all kinds of weighting matrix in mint.
As for other forms of reconciliation, do you mean top-down, middle-out and bottom-up? Yes, they can be a special case of our method that keeps the specified level immutable.

@mitchelloharawild
Copy link
Member

Yes, that's what I expected. So I think this should be implemented a bit more generally as part of the reconciliation rewrite. Do you have some sample code available for your method that I can consider for this rewrite?

@AngelPone
Copy link
Author

I implemented my method in forecast.lst_mint_mdl. I can pull a request later.

@mitchelloharawild
Copy link
Member

Oh, great. Well if it's ready to go then a PR would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants