Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] multi-arch support #87

Open
lanefu opened this issue Aug 4, 2020 · 2 comments
Open

[feat] multi-arch support #87

lanefu opened this issue Aug 4, 2020 · 2 comments

Comments

@lanefu
Copy link

lanefu commented Aug 4, 2020

this image works great.... nice-to-have would be multi arch manifest to support arm. I've tested manually and ARM64 builds clean.

@guysoft
Copy link

guysoft commented Aug 15, 2021

Hey, second that.
Unlike tiangolo/uwsgi-nginx-flask-docker#67 it is now possible to build both on Docker Hub and GitHub both arm32v7 and arm64v8 . It might be a little harder on dockerhub to put it all in to one file. but using docker buildx it should all be possible.

guysoft added a commit to guysoft/uwsgi-nginx-docker that referenced this issue Aug 15, 2021
@guysoft
Copy link

guysoft commented Aug 15, 2021

Hey, so I managed to make muliti arch builds.
I had to hack a few things off so I am not running to make PR. @tiangolo if you would like to take a look and say what is a blocker in your option I might be able to sort it out.

The main bit that was changed:
https://github.com/guysoft/uwsgi-nginx-docker/blob/dockerx/.github/workflows/deploy.yml

The special source is that it uses setup-buildx-action. It has to use its "with" statement and not "run" because it creates multiple workers based no the arch.

The output is going currently to my docker hub repo (it makes 15 docker containers!):
https://hub.docker.com/r/guysoft/uwsgi-nginx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants