Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove '< 4' constraint on Sprockets #1009

Closed
composerinteralia opened this issue Nov 10, 2019 · 1 comment
Closed

Remove '< 4' constraint on Sprockets #1009

composerinteralia opened this issue Nov 10, 2019 · 1 comment

Comments

@composerinteralia
Copy link
Contributor

composerinteralia commented Nov 10, 2019 •
edited

We locked Sprockets to < 4 in #1007 to get around some CI failures, but this constraint may make it more difficult to upgrade Rails.
composerinteralia added a commit that referenced this issue Apr 26, 2020
@composerinteralia
Remove Gemfile constraint on sprockets
dc0c1a2 
Closes #1009

We had locked the version of Sprockets to get around some test failures.
If those test failures are no longer around, we should not lock this
version.
@composerinteralia composerinteralia mentioned this issue Apr 26, 2020
Closed
@composerinteralia composerinteralia changed the title Remove '< 3' constraint on Sprockets Remove '< 4' constraint on Sprockets Apr 26, 2020
@thiagoa
Copy link
Contributor

thiagoa commented Oct 1, 2021

Thank you @composerinteralia for documenting this fix. I think we will no longer need it because we will delete our custom Gemfile as documented here:

#1082

Because of all that, I'm closing this issue. Anything we can reopen it ❤️

@thiagoa thiagoa closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Gemfile constraint on sprockets thoughtbot/suspenders
2 participants
@thiagoa @composerinteralia