-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github_repo will fail confusingly if the given revision downloads a file with a different prefix. #3000
Comments
I wasn't able to reproduce this with the following MWE:
because GitHub (correctly) returns a 404 instead of an archive:
The same happens when The thing about arcat not erroring if the value of |
Ok, so I looked into it a bit more. I would still say that please should confirm if the downloaded file actually matches, but this seems to be more related with some (intentional?) inconsistencies with github. |
Right - I suspect what happened here is that the owner(s) of The downloading of the archive in |
If a
github_repo
rule is used for a repo and the revision argument is set to something that doesnt exist, please will still download whatever the main branch is and try to runarcat
on it with the-s {expected but different prefix}
flag set.However, this makes
arcat
fail silently and some subsequent rule will then fail stating the directory that should have been given byarcat
was not found as it wasnt created in the first place.Ideally either
arcat
should report that the prefix didnt exist, or there should be a check to see if downloaded file name doesnt match what was expected.The text was updated successfully, but these errors were encountered: