Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --out flag to plz build #2927

Open
Tatskaari opened this issue Oct 16, 2023 · 3 comments
Open

Add --out flag to plz build #2927

Tatskaari opened this issue Oct 16, 2023 · 3 comments

Comments

@Tatskaari
Copy link
Member

Tatskaari commented Oct 16, 2023

It would be useful to have a --out flag e.g. plz build --out ./dir //src:please to copy plz-out/bin/src/please to ./dir/please.

When set, the build subcommand would loop through all the original targets i.e. state.ExpandOriginalLabels(). copying their outputs to the given directory:

for _, target := range state.ExpandOriginalLabels() {
	outs := state.Graph.TargetOrDie(target).FullOutputs()
        // copy the outs
}
@peterebden
Copy link
Member

I might argue for the name being --out_dir to be clearer about what it'll do. Like the idea otherwise though!

@DefinitelyNotBen
Copy link
Contributor

Hey, happy to work on this if you can assign it to me

@Tatskaari
Copy link
Member Author

Hey, happy to work on this if you can assign it to me

I'm afraid I can't assign it to you if you're not part of the org, but please do have a crack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants