Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeatherIcons #77

Open
CodyPChristian opened this issue Aug 10, 2018 · 5 comments
Open

Add FeatherIcons #77

CodyPChristian opened this issue Aug 10, 2018 · 5 comments

Comments

@CodyPChristian
Copy link

Can you add https://feathericons.com/? or I can possibly send a PR for it.

@thomaspark
Copy link
Owner

Hey @CodyPChristian, looks like a nice icon set to add, but GlyphSearch is mainly set up to do font icons. You're welcome to do a PR but may require more work than expected to get svg integrated nicely.

@jenil
Copy link
Contributor

jenil commented Aug 10, 2018

I have been waiting to add search to Icongram so I may do it this weekend, let's see 🤞

@CodyPChristian
Copy link
Author

@thomaspark Looks like two people have already converted it actually.
https://github.com/AT-UI/feather-font
https://github.com/luizbills/feather-icon-font
Thoughts?

@thomaspark
Copy link
Owner

@CodyPChristian, nice find. I do have two concerns though: most people will probably be using Feather as svg rather than icon font, so the usefulness of adding the icon font version is questionable. And not sure how well maintained these forks are relative to Feather itself. Might be better to work on the svg angle. What do you think?

@CodyPChristian
Copy link
Author

@thomaspark Hey, thanks, yeah thats a good point and makes sense actually. I was more so thinking of it spiting back the data-feather="name" attribute as it does with the other libs. However yes it is kind a blurred line due to the fact its SVG and not Icon font.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants