Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - composer #5

Open
tolzhabayev opened this issue Jul 23, 2014 · 12 comments
Open

Feature Request - composer #5

tolzhabayev opened this issue Jul 23, 2014 · 12 comments

Comments

@tolzhabayev
Copy link

Make it composer compatible and publish it on packagist

@thomasbachem
Copy link
Owner

I'm working on this, but the problem is that I'm trying to avoid putting composer.json into the root of the repository, because it belongs in src/php/composer.json. That however doesn't seem to be possible with Composer.

@tolzhabayev
Copy link
Author

I guess it's mandatory to have composer.json in the root. I don't see why it has to be in src/php/composer.json unless you want to make it cross-language which is not a common practice. Normally you will have each repository for specific language, more or less as a bundle which can be easily loaded with composer.

Anyway nice list, keep it updated :)

@thomasbachem
Copy link
Owner

I just talked to seldaek from Composer, and he confirmed that this isn't possible indeed.

I think it makes no sense to have multiple repositories if the language libraries are mostly about 20-50 lines of code each – that would make things a lot more complicated. I prefer having them in src/[lang]/.

I'll decide on this soon ;).

@sebbo2002
Copy link

I would like to build a JavaScript / node.js module, but I think we have the same problem there.

Have you thought about creating a GitHub organisation with one repository for the JSON file and n other repositories for the different implementations?

@thomasbachem
Copy link
Owner

@sebbo2002 I thought about that, but I'm really not sure about it.

Another disadvantage would be the split attention/watchers/stares between the different repositories...

@sebbo2002
Copy link

Another advantage would be, that every developer would be able to maintain his implementation (branches, tags, downloads, etc).

@thomasbachem
Copy link
Owner

Yeah, but honestly, we're talking about code that will usually be around 20-100 lines. I'm not sure one needs fancy branches for that :D.

Having two repositories to make Webmail Linker work makes using it more complicated – we would need to use submodules for the config or the user needs to check out two repositories, which is also very uncommon. How would you do it?

@sebbo2002
Copy link

I uploaded my prototype here. Before I create the tarball for npm I copy the latest JSON from your repository, so it's always bundled and can easily updated via npm/bower. New versions could be created automatically, when the JSON gets updated.

  • easy installation process (for example npm install webmail-linker)
  • update via packet manager (npm, bower or whatever)

@sebbo2002
Copy link

I'll decide on this soon ;)

Any news on this…? ;)

@davidgorges
Copy link

+1
I'd love to install this repository via bower.
I don't see a problem here. Every modern packet manager expects the configuration files in the root folder (bower, npm, composer).

@MadaManu
Copy link

https://github.com/MadaManu/angularjs-maillinker - the AngularJS flavour of this. Maybe we can integrate somehow at some point. I have registered this one on bower. I will update with documentation soon.

@pascal-hofmann
Copy link

As a workaround you can add this to your composer.json to install webmail-linker via composer:

{
   "type": "package",
   "package": {
      "name": "webmail-linker",
      "version": "0.1",
      "source": {
         "url": "https://github.com/thomasbachem/webmail-linker",
         "type": "git",
         "reference": "origin/master"
      }
   }
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants