Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Google Favicon Service to ensure up to date favicons #11

Open
MadaManu opened this issue Jul 23, 2015 · 1 comment
Open

Use Google Favicon Service to ensure up to date favicons #11

MadaManu opened this issue Jul 23, 2015 · 1 comment

Comments

@MadaManu
Copy link

I have just spotted that some of the favicons are out-dated. Maybe it would be a good idea to use google to get the favicon.

http://www.google.com/s2/favicons?domain_url=http%3A%2F%2Fwww.google.de%2F

Replace the domain_url with the web save version of the domain url and it will get all the favicons perfectly.

@thomasbachem
Copy link
Owner

I updated the URLs of all broken favicons in d98882b. The problem with using the Google Favicon Service is that most of the time you want to get the favicon from the homepage of a provider, not from the webmail site. Adding that functionality would require us to also store all provider homepages in providers.json. Keeping this ticket open for future consideration.

@thomasbachem thomasbachem changed the title Favicon detection Use Google Favicon Service to ensure up to date favicons Nov 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants