Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA coef in coxp.zph #185

Open
OdeHein opened this issue Mar 14, 2022 · 0 comments
Open

NA coef in coxp.zph #185

OdeHein opened this issue Mar 14, 2022 · 0 comments

Comments

@OdeHein
Copy link

OdeHein commented Mar 14, 2022

Hello,

Firstly, I thank you for your great work.

I frequently use the your survival package and I have recently updated it and have seen you have had changed something in the way you take into account NA coeff in the cox.zph function (since update 3.1-12).

I think, there could be issues with following lines :

186 else temp[j, i] <- fit$coefficients[j]

and

212 if (length(j) ==1) sresid[,i] <- sresid[,i] + fit$coefficients[j]

because j is an asgn value which was modified at line 71 if there are NA in coef in fit object.
And so the new asgn indicies don't correspond anymore with the original ones in fit$coefficients

Sorry, I don't have any example to illustrate it.

Am I right ?

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant