Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intents authorize will behave the same as a purchase by default #232

Open
jamieburchell opened this issue Mar 8, 2024 · 3 comments
Open

Comments

@jamieburchell
Copy link

jamieburchell commented Mar 8, 2024

Removing $data['capture_method'] = 'manual' here changes this method to behave the same as a purchase by default and not an authorization. The authorization method is supposed to require a manual capture as per the class comments:

 * An authorize request is similar to a purchase request but the
 * charge issues an authorization (or pre-authorization), and no money
 * is transferred.  The transaction will need to be captured later
 * in order to effect payment. Uncaptured charges expire in 7 days.
@jamieburchell jamieburchell changed the title Intents authorize now behaves the same as a purchase by default Intents authorize will behave the same as a purchase by default Mar 8, 2024
@jamieburchell
Copy link
Author

jamieburchell commented Mar 8, 2024

Attn: @barryvdh I believe this is a breaking change that by default will change the nature of the authorize method to become a regular payment method instead.

@barryvdh
Copy link
Member

barryvdh commented Mar 8, 2024

Yeah so do you have a PR to fix it?

@jamieburchell
Copy link
Author

jamieburchell commented Mar 8, 2024

Yeah so do you have a PR to fix it?

No. I just spotted this when trying to make sense of the readme vs code comments vs actual code and thought it was a serious issue.

I don't think it makes sense to allow the capture_method to be set at all. Authorization request == manual, payment request == automatic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants