Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error after updating package with changing field privateKey to camelCase. #80

Open
FelipeeDev opened this issue May 10, 2019 · 2 comments
Open

Error after updating package with changing field privateKey to camelCase. #80

FelipeeDev opened this issue May 10, 2019 · 2 comments

Comments

@FelipeeDev
Copy link

In response to: #79

This change shouldn't be a minor version because this class isn't final.

In other word after upgrading we occure an error becasue we overrides this class.
@frankdejonge
Copy link
Member

From my point of view, this was a bug fix, the property wasn't properly used, so this corrects it.

@FelipeeDev
Copy link
Author

I'm not saying that this wasn't a bug fix, mate. I think you should place it in at least 1.1.0 version rather then in 1.0.19. It cause an unmentioned problem as you can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankdejonge @FelipeeDev