Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathPrefix is ignored #70

Open
SamMousa opened this issue Oct 17, 2018 · 4 comments
Open

PathPrefix is ignored #70

SamMousa opened this issue Oct 17, 2018 · 4 comments

Comments

@SamMousa
Copy link

It seems this adapter fully ignores a configured path prefix.

@frankdejonge
Copy link
Member

Correct, I saw it last week. I've got it on my list for Friday. If you need it sooner a PR is welcome (with tests).

@SamMousa
Copy link
Author

Side note, the option is not really documented. Is path prefix supposed to be a guarantee from a security perspective?

@frankdejonge
Copy link
Member

The path prefix is to facilitate scoping, which is not provided now but will be when implemented. Path traversal prevention is done at a different level, the path passed to the Filesystem instance is checked for this.

@SamMousa
Copy link
Author

Alternative fix would be to have another look at my old PR for a decorator: thephpleague/flysystem#799.

The approach of a decorator is cleaner, more secure and will work for any adapter not the ones that happen to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants