Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patcher: improve UX for the server picker #428

Open
RDIL opened this issue Apr 14, 2024 · 1 comment
Open

Patcher: improve UX for the server picker #428

RDIL opened this issue Apr 14, 2024 · 1 comment
Labels
new feature Addition of a new feature, or request for a new feature. patcher Issues or pull requests targeting the patcher.

Comments

@RDIL
Copy link
Member

RDIL commented Apr 14, 2024

What

This is just a concept, see the "Why" section for details on what this aims to achieve.
In order to improve server selection, we can remove the text box in favor of only being a dropdown. Within the dropdown, we can add a divider at the bottom, and below that, a Edit server list button.

This would bring up a dialog where you can add new servers, modify existing ones, etc.
I'm thinking this could be a 2-column layout where the left hand side you select a configuration to edit and on the right is that configuration's settings. The settings can be a web/ip address, port, and display name.

This would have to be reworked in how it would work with the CLI.

Why
Right now, people have some confusion about how exactly the patcher works in terms of servers:

  • It's not entirely clear that it doubles as both a text box, and a selection for presets (e.g. "Peacock Local" is not something you can type into your browser, so it's not clear what it remaps to)
  • Adding a new server by typing it in is a strange flow (because then changing it with the dropdown overwrites that)

Additional details
Might be worth backporting any changes made in this area to LocalGhost, assuming the code changes aren't too large/implementation dependent, and assuming grape is interested.

@RDIL RDIL added new feature Addition of a new feature, or request for a new feature. patcher Issues or pull requests targeting the patcher. labels Apr 14, 2024
@VolkerSchlegel
Copy link
Member

This would absolutely be great to have, a lot of people get confused by the text box-dropdown hybrid 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Addition of a new feature, or request for a new feature. patcher Issues or pull requests targeting the patcher.
Projects
Development

No branches or pull requests

2 participants