Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peacock Patcher appears very blurry when using 125% scaling in Windows on a 1080p display #395

Closed
thecatontheceiling opened this issue Mar 3, 2024 · 8 comments · May be fixed by #388
Closed
Labels
bug Something isn't working! patcher Issues or pull requests targeting the patcher.

Comments

@thecatontheceiling
Copy link

Describe the bug
read the title

To reproduce

  1. Right click on the desktop
  2. Click "Display Settings"
  3. Set scaling to 125% (default is 100%)
  4. Open Peacock Patcher and observe
@thecatontheceiling thecatontheceiling added the bug Something isn't working! label Mar 3, 2024
@RDIL RDIL added the patcher Issues or pull requests targeting the patcher. label Mar 3, 2024
@RDIL
Copy link
Member

RDIL commented Mar 3, 2024

Hey, thanks for the report! Can you please try out our experimental core patcher and see if the issue still persists? (patcher-ui-windows artifact)

@RDIL RDIL linked a pull request Mar 3, 2024 that will close this issue
@thecatontheceiling
Copy link
Author

thecatontheceiling commented Mar 3, 2024

sure thing! do I just need to replace the .exe file with this and it shouldn't mess with anything else?

@RDIL
Copy link
Member

RDIL commented Mar 3, 2024

Correct

@thecatontheceiling
Copy link
Author

the updated patcher does not have this issue. crystal clear
image

@thecatontheceiling
Copy link
Author

why is it 200 mb though? lol
the old patcher isnt even a megabyte

@RDIL
Copy link
Member

RDIL commented Mar 4, 2024

The old patcher runs on .net framework, where it uses the system’s install of it. The new version uses .net core, which doesn’t come on windows by default like .net framework does. Also, winforms, the library used for creating the gui, does not support dead code elimination when creating complete binaries as of right now, so theres a bunch of extra winforms stuff in there not being used.

it’s not ideal, but we’re looking into ways to reduce the size before promoting the new patcher into stable.

tl:dr; we know its bigger, we’re working on it. The size comes from the combination of .net core and winforms both being bundled in.

@RDIL
Copy link
Member

RDIL commented Mar 4, 2024

Glad to hear the new patcher fixes the problem! The size concern is absolutely valid though, and it’s something we’re working on minimizing.

@thecatontheceiling
Copy link
Author

peacock 6.6.0 has the updated patcher and therefore this issue can be closed. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working! patcher Issues or pull requests targeting the patcher.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants