Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade coroutines lib version in rocket.chat connector #1458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Downgrade coroutines lib version in rocket.chat connector #1458

wants to merge 1 commit into from

Conversation

serjk
Copy link

@serjk serjk commented Feb 23, 2023 •
edited

The latest rocket.chat.sdk requires the old coroutines lib version.
#1457

@serjk serjk changed the title Downgrade coroutines lib version in rocket.chat connector Downgrade coroutines lib version in rocket.chat connector #1457 Mar 2, 2023
@serjk serjk changed the title Downgrade coroutines lib version in rocket.chat connector #1457 Downgrade coroutines lib version in rocket.chat connector Mar 2, 2023
@vsct-jburet
Copy link
Contributor

vsct-jburet commented Apr 12, 2023 •
edited

Thank you for the PR. I do not like the idea to have two coroutine versions in the classpath :(
Do you know if there is a more recent version of rocket.chat kotlin sdk ? Or may be it's easier to just add a simple http client for rocket.chat api ?

@vsct-jburet vsct-jburet self-assigned this Apr 12, 2023
@serjk
Copy link
Author

serjk commented Apr 12, 2023 •
edited

@vsct-jburet I agree that is not the best solution....
Rocket.Chat.sdk contains the fix but only on develop branch. The latest published lib doesn't contain required changes.
Develop branch: https://github.com/RocketChat/Rocket.Chat.Kotlin.SDK/blob/develop/dependencies.gradle#L5
Latest release: https://github.com/RocketChat/Rocket.Chat.Kotlin.SDK/blob/982d97a169f5e7b613ed0bd3c2554d3fb55fff07/dependencies.gradle#L5

I've also written to a guy who published the last release version to maven central. He doesn't work under this project and said that this project has been deprecated.

Will have a look at adding a simple http client for rocket.chat api.

@francoisno francoisno linked an issue Aug 3, 2023 that may be closed by this pull request
[Bug] Rocket.Chat connector gets an exception during connection #1457
Open
@francoisno francoisno added the bug label Aug 3, 2023
@francoisno francoisno added this to the 23.3.4 milestone Aug 3, 2023
@vsct-jburet vsct-jburet modified the milestones: 23.3.4, 23.9.0 Sep 3, 2023
@vsct-jburet vsct-jburet modified the milestones: 23.9.0, 24.3.0 Oct 8, 2023
@vsct-jburet vsct-jburet modified the milestones: 24.3.0, 24.9.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsct-jburet vsct-jburet

Labels
bug
Projects
None yet
Milestone
24.9.0
Development

Successfully merging this pull request may close these issues.

[Bug] Rocket.Chat connector gets an exception during connection
3 participants
@serjk @vsct-jburet @francoisno