Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing node-pre-gyp? #117

Open
olivierthereaux opened this issue May 21, 2019 · 1 comment
Open

Missing node-pre-gyp? #117

olivierthereaux opened this issue May 21, 2019 · 1 comment

Comments

@olivierthereaux
Copy link
Contributor

I ran through the process of building locally from repo today, and think there are a few issues with the dependencies management:

  1. There is an expectation of node version 8.9.3, which I think could be relaxed
  2. I believe there is a dependency on node-pre-gyp (not just gyp) which, if the environment does not have it otherwise installed, breaks the build/install.
  3. I do end up with a running local server, but all the assets are missing (and thus the site is a little spartan) - but that might be user error.
@tomdavies
Copy link
Collaborator

@olivierthereaux thanks for this. Due to resourcing constraints, this project hasn't had a lot of love in the past year, but we hopefully have some development time for it coming up in the next few months. Unfortunately, until then, these issues aren't likely to get fixed quickly. Feel free to open a PR though and I'll try and review it in a timely way.

In terms of the implicit node-pre-gyp dependency, I suspect this may relate to the version of Sass being used behind the scenes by the front end build toolchain. We'll be updating the build chain as part of the work this summer which will likely remove this issue anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants