You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently the validation badges on the GH Pages site only validate the CSV on its own, and do not validate the CSV against the schema, e.g. https://csvlint.io/?uri=https://caiwilliamson.github.io/test2/data/test2.csv&format=svg. I think it's possible to provide the url of a schema within that url (https://csvlint.io/documentation) to get the correct validation. For the static GH Pages site to be able to refer to the url of the schema file it needs to be in the git repo. And it is!
However, the schema file is only created in the repo on first publish (if you supply a schema) and never touched again. When the schema is changed it is actually updated in the datapackage.json (GH Pages site reads from this). Maybe someone was in the process of changing how this works and didn't finish. If you plan to fix the validation badges, you would need to ensure you also keep the schema file in the repo up to date (in the jekyll service).
Note: Octopub also generates validation pages using the csvlint gem internally e.g. /collection/53/file/64/validation. These results do validate the CSV against the schema. You may figure out a way to shove these links into the static html file for the GH Pages site by precompiling it somehow but it doesn't look trivial.
Currently the validation badges on the GH Pages site only validate the CSV on its own, and do not validate the CSV against the schema, e.g. https://csvlint.io/?uri=https://caiwilliamson.github.io/test2/data/test2.csv&format=svg. I think it's possible to provide the url of a schema within that url (https://csvlint.io/documentation) to get the correct validation. For the static GH Pages site to be able to refer to the url of the schema file it needs to be in the git repo. And it is!
However, the schema file is only created in the repo on first publish (if you supply a schema) and never touched again. When the schema is changed it is actually updated in the datapackage.json (GH Pages site reads from this). Maybe someone was in the process of changing how this works and didn't finish. If you plan to fix the validation badges, you would need to ensure you also keep the schema file in the repo up to date (in the jekyll service).
Note: Octopub also generates validation pages using the csvlint gem internally e.g. /collection/53/file/64/validation. These results do validate the CSV against the schema. You may figure out a way to shove these links into the static html file for the GH Pages site by precompiling it somehow but it doesn't look trivial.
Related issue:
#953 (comment)
The text was updated successfully, but these errors were encountered: