Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use example_anndata.h5ad for tests/examples #27

Open
lazappi opened this issue Dec 3, 2020 · 3 comments
Open

Use example_anndata.h5ad for tests/examples #27

lazappi opened this issue Dec 3, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@lazappi
Copy link
Member

lazappi commented Dec 3, 2020

This file is more complete than the krumsiek11.h5ad file currently used and should be a better test of a standard conversion.

The file is slightly large (~1.2 MB) so might be worth zipping it (zipped size is ~300 kB). If that is done need to do something like this before trying to read it in:

tmp <- tempdir()
zip.file <- system.file("extdata", "example_anndata.h5ad.zip", package = "zellkonverter")
unzip(zip.file, exdir = tmp)
file <- file.path(tmp, "example_anndata.h5ad")

Ideally this would be wrapped in a function so you can just do:

file <- getExamplePath()
@lazappi lazappi added the enhancement New feature or request label Dec 3, 2020
@LTLA
Copy link
Contributor

LTLA commented Dec 3, 2020

Could just stick it on ExperimentHub and have zellkonverter Suggests EHub to pull it down. In fact, with this approach, you could put any number of arbitrarily large files and then make longtests to check that they are correctly converted; see DropletUtils and its relationship with the DropletTestFiles package.

@lazappi
Copy link
Member Author

lazappi commented Dec 4, 2020

Ah, yes. I knew you suggested something like that but I couldn't remember what. Thanks for the reminder!

Do you think 1.2MB is big enough to worry about or should I just leave this for bigger test datasets?

@LTLA
Copy link
Contributor

LTLA commented Dec 4, 2020

IMO I wouldn't think of it as a "worry", more of an investment for the future. Once paid, you have the process to just easily whack on more files to, e.g., check behavior with updates or new versions of the format. It's probably a good time to get any EHub teething problems out of the way, given that nothing in devel is critically broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants