Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualenv conditional #9

Open
thefinn93 opened this issue Jan 20, 2016 · 6 comments
Open

virtualenv conditional #9

thefinn93 opened this issue Jan 20, 2016 · 6 comments

Comments

@thefinn93
Copy link
Owner

Installation of the virtualenv package doesn't work on older OSs (older than Debian jessie or Ubuntu Vivid), but on newer OSs need it over python-virtualenv (see #6). We should improve the conditional to reflect this nuance.

@pmackay
Copy link
Contributor

pmackay commented Jun 1, 2016

I'd like to get this role working on Ubuntu 14.04. Would pmackay@e47e389 be ok to do a PR? Not sure if this generalizes the solution enough though.

@thefinn93
Copy link
Owner Author

eh i guess. Not ideal but whatever. Maybe someone will come along and fix it all one day...

@pmackay
Copy link
Contributor

pmackay commented Jun 2, 2016

Do you happen to know of any matrix that lists all the distributions and versions? And a simple way to determine the right package for each? Or is it a case of trial and error testing or looking up for each one?

@pmackay
Copy link
Contributor

pmackay commented Jun 2, 2016

I've done a more generalized approach here pmackay@f0d33e7. Does that seem OK?

Have also created a travis-test branch that sets up testing the role on Travis, which I could also raise a PR for if that sounds useful?

@thefinn93
Copy link
Owner Author

PR the travis branch for sure! I'm wrapping of my last quarter of university so I'm gonna be focusing on finals for a bit, I'll take a look at the other thing sometime next week

@pmackay
Copy link
Contributor

pmackay commented Jun 3, 2016

Have created #34, feedback welcome whenever is convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants