Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatible with a Web Socket Server? #2

Open
DetweilerRyan opened this issue Aug 11, 2016 · 3 comments
Open

compatible with a Web Socket Server? #2

DetweilerRyan opened this issue Aug 11, 2016 · 3 comments

Comments

@DetweilerRyan
Copy link

Although, I have not confirmed this with any tests, It seems to me that the shutdown method would prematurely close sockets on an http server used as the backend for a WebSocket server. It seems to me that the sockets that pass through the 'connection' event and never pass through the 'request' event because they are used in the WebSocket server will always be seen as idle and will be destroyed on shutdown even if the sockets are still being used by the WebSocket server.

@thedillonb
Copy link
Owner

Yeah, I've never tried with a WS but I'd assume what you have that it probably doesn't work correctly.

@MitMaro
Copy link

MitMaro commented Dec 14, 2016

I ended up having to write something to handle WebSockets: https://github.com/MitMaro/node-server-shutdown

@karlpokus
Copy link
Contributor

Shouldn't a websocket be regarded similar to a keep-alive? Thus should not accept traffic post the close call?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants