Skip to content
This repository has been archived by the owner on Jul 2, 2022. It is now read-only.

Insecure password storage #1

Open
mxsasha opened this issue Sep 9, 2013 · 3 comments
Open

Insecure password storage #1

mxsasha opened this issue Sep 9, 2013 · 3 comments
Assignees

Comments

@mxsasha
Copy link

mxsasha commented Sep 9, 2013

The username and password of the configured account are stored in a SQLite database. The database file does not use iOS' data protection, so it is readable to anyone with physical access to the device.

The best solution would be to store the password not in SQLite, but in the Keychain, which was designed exactly for this purpose.

@ghost ghost assigned thedillonb Sep 10, 2013
@thedillonb
Copy link
Owner

Great point. I will use your suggestion and store it in the keychain. This will be in the next release.

@jai
Copy link

jai commented Jul 24, 2016

Hey @thedillonb just checking if this is being worked on? If not I'll check it out

@thedillonb
Copy link
Owner

No this is not being worked on. I had originally de-prioritized this due to the fact that the app is now using token based authentication that requires a token refresh every hour so the only thing you could extract from the device would be expired tokens - unless you lost your device and somebody found it and immediately extracted it within an hour.

Regardless, you're welcome to work on it. There's some code already in the AppDelegate.cs around keychain access so you might be able to leverage that code.

Thanks for your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants