Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preValdiation doesn't pass the computed state to the validation functions #304

Open
gmmorris opened this issue Aug 28, 2015 · 2 comments
Open

Comments

@gmmorris
Copy link

When you call preValidate the computedState doesn't include the attributes passed to preValidate, but rather the model attributes.
This differs from the regular validate functionality which means validation functions that depend on multiple attributes break (true, not an idea situation anyway, but sometime you need that and the behaviour should be uniform in both usages).

@gmmorris
Copy link
Author

Made a fix and submitted a pull request (#303)

I wasn't sure what your versioning and releasing procedure is, so I haven't changed the version - let me know if you wish for me to bump the minor version.

@austing
Copy link

austing commented Apr 26, 2016

This is a serious problem, but the pull request is almost a year old, and nobody has replied to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants