Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox e2e tests are persistently failing #653

Open
ml-evs opened this issue Mar 20, 2024 · 5 comments · Fixed by #699 · May be fixed by #711
Open

Firefox e2e tests are persistently failing #653

ml-evs opened this issue Mar 20, 2024 · 5 comments · Fixed by #699 · May be fixed by #711
Assignees
@ml-evs
Labels
testing For issues/PRs that change how the package is tested

Comments

@ml-evs
Copy link
Member

ml-evs commented Mar 20, 2024

I think in my haste something has actually broken in the Firefox E2E testing, as its now failing for PRs that don't change much. I'll try to find time to investigate this soon.
@ml-evs ml-evs self-assigned this Mar 20, 2024
@ml-evs ml-evs added the testing For issues/PRs that change how the package is tested label Mar 20, 2024
@ml-evs
Copy link
Member Author

ml-evs commented Mar 21, 2024

Looks like this is an upstream problem: cypress-io/cypress#29172 (comment)

Can keep this open until we no longer see the failures

@ml-evs ml-evs mentioned this issue Mar 21, 2024
Merged
@ml-evs
Copy link
Member Author

ml-evs commented Mar 22, 2024

This fix has been made upstream in cypress, we now just need to see how quickly it percolates down to the GitHub action we use. I'd prefer to wait rather than pinning specific browser versions in our CI.

@ml-evs ml-evs mentioned this issue Mar 22, 2024
Merged
@ml-evs
Copy link
Member Author

ml-evs commented Apr 12, 2024

Ok it was nothing to do with waiting for the action to release; the action just uses whatever cypress version we have installed, so updating should fix it.

@ml-evs ml-evs mentioned this issue Apr 12, 2024
Merged
@ml-evs
Copy link
Member Author

ml-evs commented Apr 13, 2024

Think we're now seeing some "real" firefox failures after merging #699...

@ml-evs ml-evs mentioned this issue Apr 16, 2024
Merged
@ml-evs
Copy link
Member Author

ml-evs commented Apr 16, 2024

Reopened by #703

@ml-evs ml-evs reopened this Apr 16, 2024
@ml-evs ml-evs linked a pull request Apr 19, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
testing For issues/PRs that change how the package is tested
Projects
None yet
Milestone
No milestone
1 participant
@ml-evs