Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix peer dependency please for react #1032

Open
Krasnopir opened this issue Nov 27, 2020 · 2 comments · May be fixed by #1038
Open

fix peer dependency please for react #1032

Krasnopir opened this issue Nov 27, 2020 · 2 comments · May be fixed by #1038

Comments

@Krasnopir
Copy link

Krasnopir commented Nov 27, 2020 •
edited

"react": "^0.14.0 || ^15.0.0 || ^16.0.0"

17 react was relesed and work fine with this package, but on install there are peer dependency warning

npm WARN react-text-mask@5.4.3 requires a peer of react@^0.14.0 || ^15.0.0 || ^16.0.0 but none is installed. You must install peer dependencies yourself.
@jimisaacs
Copy link

This was just a warning, now with npm 7 it installs peer dependencies, and with bit, this just fails isolated builds. Can we please update the peer deps.

@jimisaacs
Copy link

@msafi if you are no longer maintaining this project, please allow someone else to. There's far too many dependents to let it die.

@eps1lon eps1lon mentioned this issue Mar 19, 2021
Merged
12 tasks
@m4theushw m4theushw mentioned this issue Apr 2, 2021
Merged
6 tasks
@samheutmaker samheutmaker linked a pull request Apr 15, 2021 that will close this issue
Open
@felix-last felix-last mentioned this issue Oct 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update peer dependencies for react-text-mask to include React 17 biproxi/text-mask
2 participants
@jimisaacs @Krasnopir