You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In my project, after upgrading ATL to v16, that difference occurred version conflict errors at test. I solved that by adding TL/dom v10 to my own package.json to make TL/user-event to use v10.
I think my situation did not happen if the both libraries depend on TL/dom by the same peerDependencies way.
How do you think? Could we change this dependency? @timdeschryver
The text was updated successfully, but these errors were encountered:
Yea, this is similar to testing-library/react-testing-library#1305
Tbh, I liked that users could just install ATL and use it.
But, I think we reached a point where we need to have it as a peerDependency.
I was planning to do that when Angular 18 is released as this would result in a breaking change.
This will probably land later, as the upgrade to Angular 18 isn't breaking.
If you want to help with this feel free to drop a message and I'll create the beta branch.
ATL depends on TL/dom directly, but TL/user-event depends on that via
peerDependencies
.https://github.com/testing-library/angular-testing-library/blob/main/projects/testing-library/package.json#L38
https://github.com/testing-library/user-event/blob/main/package.json#L73
In my project, after upgrading ATL to v16, that difference occurred version conflict errors at test. I solved that by adding TL/dom v10 to my own
package.json
to make TL/user-event to use v10.I think my situation did not happen if the both libraries depend on TL/dom by the same
peerDependencies
way.How do you think? Could we change this dependency? @timdeschryver
The text was updated successfully, but these errors were encountered: