Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cicerone#setRouterFabic suggestion #95

Open
Buckstabue opened this issue Nov 19, 2018 · 0 comments
Open

Cicerone#setRouterFabic suggestion #95

Buckstabue opened this issue Nov 19, 2018 · 0 comments

Comments

@Buckstabue
Copy link

Buckstabue commented Nov 19, 2018

Currently, in order to create a cicerone instance with a custom router, one has to pass a custom router instance on every Cicerone creation and it's very easy to forget to pass it and default router would be created. I suggest to introduce a static setter for a custom router fabric which is used when calling Cicerone.create(). This approach is used by many libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants