Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why removing the optimize in cargo.toml? #28

Open
bbqaaq opened this issue Apr 14, 2022 · 6 comments
Open

Why removing the optimize in cargo.toml? #28

bbqaaq opened this issue Apr 14, 2022 · 6 comments
Labels
question Further information is requested

Comments

@bbqaaq
Copy link

bbqaaq commented Apr 14, 2022

Starting the commit #17 , this

@emidev98
Copy link
Contributor

Hello @bbqaaq, there is an issue on going with some library versions. You can find more context here #19

@bbqaaq
Copy link
Author

bbqaaq commented Apr 15, 2022

So may I ask if terrain will support workspace later? Currently terrain got problems with multi-contracts
or workspace setup.

Indeed I got problems with the terrain setup, as workspace is not working with current terrain.
See iboss-ptk/terrain#26 and I do some suggestions here.

#19 won't convince me to remove the optimize command, unless the repo one can cover 100% cases of usage.
I just need to override the #17 change and revert the code on my local machine terrain.

@bbqaaq
Copy link
Author

bbqaaq commented Apr 28, 2022

@emidev98 Can you please not just close my issue? As Im telling some actual usage during development.
Workspace setup for contract development is common, and now it's not working with that.

I have my own optimize script to deal with it, and if this feature is officially close, I will just need to modify it on my local machine forever.

@emidev98 emidev98 reopened this Apr 28, 2022
@emidev98
Copy link
Contributor

Hey @bbqaaq,

I have seen that the original issue you opened is on the iboss-ptk repository and there is no support to that repository from here. Regarding the PR you have had to revert I understand your concerns, as you can imagine Terrain needs to provide the best experience for the developers and #17 was necessary to do not mix 0.16 with 1.0.0-beta packages (from cosmwasm).

Aside of that as you have a custom integration of terrain if you like you can create a proposal like this one #39 to integrate your custom feature to the main repo.

Regards,
Emi

@bbqaaq
Copy link
Author

bbqaaq commented Apr 29, 2022

Thanks Emi.

I will gather my way of tackling workspace problem.
Will submit a PR to this repo once Im ready.

@emidev98
Copy link
Contributor

emidev98 commented May 2, 2022

Cool! Thank you everyone is welcome to collaborate to the repo

@emidev98 emidev98 added the question Further information is requested label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants