Reject toPrompt Promise when 'exit' is emitted. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the 'autocomplete' prompt incorrectly firing onSubmit when it is exitted by pressing ESC. Now correctly fires onCancel.
|
Any ideas when this PR will be merged? |
|
is this project not maintained? such a big bug persist so long without merged |
TakshPSingh
added a commit
to withgraphite/prompts
that referenced
this pull request
Feb 5, 2024
this is an open issue in the library: terkelg#362 here's a fix for this that someone made a while ago (which has not been merged for some reason): terkelg#369 This PR makes the same fix in our internal fork
TakshPSingh
added a commit
to withgraphite/prompts
that referenced
this pull request
Feb 5, 2024
this is an open issue in the library: terkelg#362 here's a fix for this that someone made a while ago (which has not been merged for some reason): terkelg#369 This PR makes the same fix in our internal fork
TakshPSingh
added a commit
to withgraphite/prompts
that referenced
this pull request
Feb 5, 2024
this is an open issue in the library: terkelg#362 here's a fix for this that someone made a while ago (which has not been merged for some reason): terkelg#369 This PR makes the same fix to our fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #362
This fixes the 'autocomplete' prompt incorrectly firing onSubmit when it is exitted by pressing ESC. Now correctly fires onCancel.