Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFX 1.13.0-rc0 Issues #5854

Open
rtg0795 opened this issue Apr 15, 2023 · 2 comments
Open

TFX 1.13.0-rc0 Issues #5854

rtg0795 opened this issue Apr 15, 2023 · 2 comments
Assignees
Labels

Comments

@rtg0795
Copy link
Contributor

rtg0795 commented Apr 15, 2023

Please comment or link any issues you find with TFX 1.13.0-rc0.

Thanks.

@jooon
Copy link

jooon commented Apr 17, 2023

I see that this version has loosened up the dependency on the protobuf version. This is great. We can almost upgrade now. However, can you do the same with docker? I am not sure it needs to be '<5'. Version 5 did not change any api as far as I know, only dropped support for python 2.

@jcugat
Copy link

jcugat commented Apr 17, 2023

I'd like to also see support for both docker 4 and 5, there are no incompatible APIs between the two. In fact I did a similar change in the Flyte repo recently and there weren't any issues: flyteorg/flytekit#1536

Would be great to set it at least to docker>=4.0.0,<7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants