New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS build configuration #4270
base: main
Are you sure you want to change the base?
Add macOS build configuration #4270
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
b8772fa
to
5f2b2a9
Compare
* Add bazel configuration to properly build macOS version * Adjust codebase to make it compatible with the latest Apple's clang and ld * Improve usability of build_python_package.sh * Add a hack to "better" identify the package's platform
5f2b2a9
to
bd081bd
Compare
cc: @michaelreneer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dropped support for MacOS because it was costly to maintain. I think before we accept a change like this we would need to discuss restoring official support for MacOS. Can we retain this PR (so we don't lose this work) and start some discussions for what that would look like?
Is there anything I can help with? |
Was Mac OS Support ever added back? |
With the recent advancements in
tensorflow-metal
and large GPU shared memory variant, macOS is becoming a more attractive platform for federated experimentation. This PR adds the required configuration to buildtensorflow-federated
for macOS running on Apple Silicon.The build succeeds on my current MacBook Pro M2, the PR is code-complete and seems to run "Hello, World" successfully. Going through the more thorough testing right now.
Verification:
details
Partially implements #3881. Publication of a prebuilt package is still blocked due to
tensorflow-text
andtensorflow-compression
missing macOS builds (although staying buildable from sources).