Update TFF to use the new standard format to describe project metadata declaratively. #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
cl/572583124
branch
5 times, most recently
from
5b95310
to
129ff08
Compare
|
Just curious. Two questions:
|
evgri243
reviewed
Nov 8, 2023
| python "tensorflow_federated/tools/python_package/setup.py" bdist_wheel \ | ||
| --plat-name=manylinux_2_31_x86_64 | ||
| pip install --upgrade build | ||
| python -m build --wheel |
There was a problem hiding this comment.
What platform is set for the package in this case?
copybara-service
bot
force-pushed
the
cl/572583124
branch
3 times, most recently
from
e5bd080
to
a87fc6e
Compare
copybara-service
bot
force-pushed
the
cl/572583124
branch
from
a87fc6e
to
d967f89
Compare
copybara-service
bot
changed the title
What do you mean by dev installations? Do you mean creating a developer environment typically done using I think yes. Maybe this is what you are looking for https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#dependencies-and-requirements or possibly https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#platform-specific-dependencies |
copybara-service
bot
force-pushed
the
cl/572583124
branch
from
d967f89
to
e0d5406
Compare
…a declaratively. See https://peps.python.org/pep-0621/ PiperOrigin-RevId: 572583124
copybara-service
bot
force-pushed
the
cl/572583124
branch
from
e0d5406
to
9c53b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update TFF to use the new standard format to describe project metadata declaratively.
See https://peps.python.org/pep-0621/