Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adanet.ensemble.Ensembler not used in Tutorials? #148

Open
le-dawg opened this issue Apr 7, 2020 · 5 comments
Open

adanet.ensemble.Ensembler not used in Tutorials? #148

le-dawg opened this issue Apr 7, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@le-dawg
Copy link

le-dawg commented Apr 7, 2020

Obsolete
Apparently I was incorrect in my assessment!
@cweill I have been stumbling upon discrepancies between docs and code a few times in the examples and I want to phrase this as a question:

# TODO: Delete deprecated build_mixture_weights_train_op method.
# Use adanet.ensemble.Ensembler instead.

According to the doc and original paper this would imply that the tutorials actually do not form ensembles. Is that the case?

@le-dawg le-dawg closed this as completed Apr 7, 2020
@cweill
Copy link
Contributor

cweill commented Apr 7, 2020

@le-dawg I think you make a good point: we need to update our tutorials to use the tf.ensemble.Ensemblers.

@cweill cweill reopened this Apr 7, 2020
@cweill cweill added the enhancement New feature or request label Apr 7, 2020
@cweill cweill self-assigned this Apr 7, 2020
@le-dawg
Copy link
Author

le-dawg commented Apr 7, 2020

Updated OP.

@le-dawg
Copy link
Author

le-dawg commented Apr 14, 2020

Can you point me to any reference implementation? I have deriived my Builder and Generator classes from the tutorial definition but I am stuck trying to determine wehterh and als HOW my AdaNet instance is Ensembling. Given that build.mixtureweight doesnt compute anything I wonder what the final ensembles look like. @cweill

@le-dawg
Copy link
Author

le-dawg commented Apr 14, 2020

Edited the typos, I have a freshly fractured hand :/

@cweill
Copy link
Contributor

cweill commented Apr 17, 2020

According to the doc and original paper this would imply that the tutorials actually do not form ensembles. Is that the case?

They still create ensembles, it just that we now use the adanet.ensemble.Ensembler suclasses to handle this feature. In the tutorials, they were using the old method with the build_mixture_weights. The same behavior can be found in the adanet.ensemble.ComplexityRegularizedEnsembler class, which will create one new candidate ensemble per subnetwork per iteration, where the ensemble is composed of the previous iteration's ensemble and new subnetwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants