Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo-semver-checks to CI checks #963

Open
WaffleLapkin opened this issue Nov 5, 2023 · 2 comments
Open

Add cargo-semver-checks to CI checks #963

WaffleLapkin opened this issue Nov 5, 2023 · 2 comments
Assignees
@syrtcevvi
Labels
A-meta Area: meta (ci, repo configuration, licensing, etc) call for contribution Request for help from the community/contributors K-enhancement Kind: enchantment (new feature or request) S-blocked Status: this is blocked on something

Comments

@WaffleLapkin
Copy link
Member

WaffleLapkin commented Nov 5, 2023 •
edited by teloxidebot

It is known that Rust rules about breaking changes are tricky, so it's best we add cargo-semver-checks to CI, so that we don't accidentally do a breaking change in a minor release.
@WaffleLapkin WaffleLapkin added the K-enhancement Kind: enchantment (new feature or request) label Nov 5, 2023
@WaffleLapkin WaffleLapkin added the call for contribution Request for help from the community/contributors label Nov 29, 2023
@WaffleLapkin WaffleLapkin added the A-meta Area: meta (ci, repo configuration, licensing, etc) label Jan 21, 2024
@syrtcevvi
Copy link
Contributor

@teloxidebot claim

@syrtcevvi syrtcevvi mentioned this issue Feb 9, 2024
Closed
@WaffleLapkin
Copy link
Member Author

#1007 (comment)

@teloxidebot label +S-blocked

@teloxidebot teloxidebot added the S-blocked Status: this is blocked on something label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syrtcevvi syrtcevvi

Labels
A-meta Area: meta (ci, repo configuration, licensing, etc) call for contribution Request for help from the community/contributors K-enhancement Kind: enchantment (new feature or request) S-blocked Status: this is blocked on something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add cargo-semver-checks job to CI syrtcevvi/teloxide
3 participants
@WaffleLapkin @syrtcevvi @teloxidebot