Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: make requester_forward macro public #822

Open
DCNick3 opened this issue Jan 24, 2023 · 0 comments
Open

Feature Request: make requester_forward macro public #822

DCNick3 opened this issue Jan 24, 2023 · 0 comments
Assignees
Labels
A-requester Area: requester trait, bot adaptors K-feature-request Kind: request for implementing a feature

Comments

@DCNick3
Copy link

DCNick3 commented Jan 24, 2023

Expose requester_forward macro, which can be used to implement adapters in 3rd party crates with less maintenance.

I, myself, am looking into this to implement adapter for tracing the requests and their responses as tracing spans (instead of just log messages, as does the adapter included upstream)

(discussed previously at #821)

Pros

  • Allows the user to implement their own bot adapter without much boilerplate and without the requirement to maintain their own macros for this

Cons

  • A bit larger maintenance burden, wouldn't be able to change it w/o a breaking release

Alternatives

Include tracing adapter upstream. No real alternatives for general 3rd-party adapter development

@DCNick3 DCNick3 added the K-feature-request Kind: request for implementing a feature label Jan 24, 2023
@WaffleLapkin WaffleLapkin added the A-requester Area: requester trait, bot adaptors label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-requester Area: requester trait, bot adaptors K-feature-request Kind: request for implementing a feature
Projects
None yet
Development

No branches or pull requests

3 participants