Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove format from StickerSet #1050

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove format from StickerSet #1050

wants to merge 3 commits into from

Conversation

avoonix
Copy link

@avoonix avoonix commented Apr 18, 2024 •
edited

fixes #1038

  • CHANGELOG.md is updated (if necessary)
  • Documentation and tests are updated (if necessary)

@teloxidebot
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @teloxidebot author: the review is finished, PR author should check the comments and take action accordingly
  • @teloxidebot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@teloxidebot teloxidebot added A-tba-types Area: representation of telegram bot API types C-core crate: teloxide-core S-waiting-on-review Status: Awaiting review from the assignee labels Apr 18, 2024
WaffleLapkin
WaffleLapkin reviewed May 22, 2024
View reviewed changes
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to merge this, given that we usually do all changes from an API version at once, but I suppose this is fine as a bugfix ...

Can you add a test for #1038? (i.e. copy the json from the error message and test that we can deserialize it properly)

crates/teloxide-core/src/types/sticker_set.rs
@@ -20,10 +20,6 @@ pub struct StickerSet {
#[serde(flatten)]
pub kind: StickerType,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the type still shared by all stickers?

@WaffleLapkin WaffleLapkin added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author and removed S-waiting-on-review Status: Awaiting review from the assignee labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@WaffleLapkin WaffleLapkin

Labels
A-tba-types Area: representation of telegram bot API types C-core crate: teloxide-core S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse Error: Data did not match any variant of untagged enum TelegramResponse for getStickerSet
3 participants
@avoonix @teloxidebot @WaffleLapkin