Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Upgrade reqwest crate #1034

Open
GreenYun opened this issue Mar 30, 2024 · 1 comment
Open

Feature Request: Upgrade reqwest crate #1034

GreenYun opened this issue Mar 30, 2024 · 1 comment
Assignees
@WaffleLapkin @Hirrolot
Labels
K-proposal Kind: proposal to add something new/change existing design

Comments

@GreenYun
Copy link

reqwest 0.12 is out and it have many approvement without breaking too much. I think teloxide-core may replace the version requirement "0.11.10" with ">=0.11.10".

Pros

HTTP(2) improvements; no need to build duplicate codes when coping with other crates that needs reqwest 0.12.

Cons

Efforts will be taken to make sure that everything works well.

Alternatives

N/A
@GreenYun GreenYun added the K-feature-request Kind: request for implementing a feature label Mar 30, 2024
@WaffleLapkin
Copy link
Member

WaffleLapkin commented Mar 31, 2024 •
edited

I don't think using >= dependencies is a good idea. Updating reqwest to simply 0.12 seems fine though. (feel free to open a PR)

@WaffleLapkin WaffleLapkin added K-proposal Kind: proposal to add something new/change existing design and removed K-feature-request Kind: request for implementing a feature labels Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WaffleLapkin WaffleLapkin

@Hirrolot Hirrolot

Labels
K-proposal Kind: proposal to add something new/change existing design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GreenYun @WaffleLapkin @Hirrolot