Is it safe to drop Dispatcher's Future?

[istudyatuni]

As stated in #711 (comment) , it's possible to just drop Dispatcher's Future without waiting for long shutdown. Question is, is it safe to do so? Probably when stopping, some important tasks are executed?

[WaffleLapkin]

It depends on definition of "safe". In rust terms: yes it's safe (i.e. can't lead to unsoundness).

However it will mean that

1. Handlers are not guaranteed to run till completion
2. You may receive some updates a second time when restarting the bot (that's relatively unlikely, but possible)

You may also want to build teloxide from master branch (i.e. via a git= dependency and a pinned commit), because #938 fixes the problem with very long shutdowns.

[istudyatuni]

Handlers are not guaranteed to run till completion

So theoretically the handler could fail to complete processing the update and the update would be lost? If I understand telegram API correctly

because #938 fixes the problem with very long shutdowns

Saw this, but it's not super necessary rn, I can just wait for release 😌

[WaffleLapkin]

So theoretically the handler could fail to complete processing the update and the update would be lost? If I understand telegram API correctly

No. Failed handlers don't affect update handling.

An update would be lost if handler started running, but then hard-shutdown happened and the handler did not finish.

[istudyatuni]

Got it, thanks!