Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This docker-compose file is completely broken #11

Open
amalic opened this issue Nov 21, 2018 · 1 comment
Open

This docker-compose file is completely broken #11

amalic opened this issue Nov 21, 2018 · 1 comment

Comments

@amalic
Copy link

amalic commented Nov 21, 2018

  • The .env which is being mounted does not exist.
  • Usage of $PWD doesn't make any sense since docker-compose can resolve relative paths.
  • An environment variable called $ROOT is being used and you expect a cert folder in it. In the nginx sub-folder you try to use letsencrypt. It would be smarter to not do https in your web-application but rather delegate it to something like jwilder/nginx-proxy with letsencrypt-companion
  • There is no need to map all exposed ports. I would recommend to only map port 80 of the web application. Within the docker-compose infrastructure all containers can access each other via network using the service-name from the docker-compose file.
@Leopere
Copy link
Contributor

Leopere commented Feb 8, 2019

Theres a bunch of stuff wrong with the docker-compose file like how the compose file is pulling a broken and outdated docker container image. There's really no indication that the main branch of the app is stable it seems and the main developer doesn't seem to be in their own Gitter.im channel. I PR'd a few adjustments recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants